Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Collect pull mode cluster logs for E2E #1843

Conversation

XiShanYongYe-Chang
Copy link
Member

Signed-off-by: changzhen [email protected]

What type of PR is this?

/kind flake

What this PR does / why we need it:

Collect pull mode cluster (In our test, it is member3 cluster) logs.

Which issue(s) this PR fixes:
Part of #1841

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

@karmada-bot karmada-bot added the kind/flake Categorizes issue or PR as related to a flaky test. label May 20, 2022
@karmada-bot karmada-bot requested review from lfbear and mrlihanbo May 20, 2022 02:49
@karmada-bot karmada-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label May 20, 2022
@XiShanYongYe-Chang XiShanYongYe-Chang changed the title Collect pull mode cluster logs Collect pull mode cluster logs for E2E May 20, 2022
Copy link
Member

@RainbowMango RainbowMango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

/hold
Please check if it really works.

@karmada-bot karmada-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 20, 2022
@karmada-bot karmada-bot added the lgtm Indicates that a PR is ready to be merged. label May 20, 2022
@karmada-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: RainbowMango

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@karmada-bot karmada-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 20, 2022
@XiShanYongYe-Chang
Copy link
Member Author

XiShanYongYe-Chang commented May 20, 2022

image

image

It works ok.

@XiShanYongYe-Chang
Copy link
Member Author

/hold cancel

@karmada-bot karmada-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 20, 2022
@karmada-bot karmada-bot merged commit 4d5428e into karmada-io:master May 20, 2022
@XiShanYongYe-Chang XiShanYongYe-Chang deleted the collect-pull-mode-cluster-logs branch May 20, 2022 08:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/flake Categorizes issue or PR as related to a flaky test. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants